[core] Add react-is dependency #18551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
eps1lon
previously requested changes
Nov 25, 2019
added 2 commits
November 25, 2019 11:31
This dependency is called in Menu.js but is not listed in package.json
|
No bundle size changes comparing 73fb52a...7311379 |
eps1lon
reviewed
Nov 25, 2019
I also noticed that material-ui-utils is using react 16.8.0 and react-utils 16.8.6. Is this wanted or it's an issue ? @eps1lon |
oliviertassinari
approved these changes
Nov 25, 2019
|
@HeadFox It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
|
I'm using material-ui since the v1 ! |
|
@HeadFox awesome. If you could change, add, or remove one thing in the framework, what would it be? |
2 tasks
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is called in Menu.js but is not listed in package.json
I detected this problem when I runned a project with yarn berry (v2) using pnp.
The Menu.js component is using 'isFragment' function from the react-is library.
The only package.json that have react-is is in @material-ui/utils.
This change is also related to the #17317