-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Radio][Checkbox] Add size="small" support #18688
[Radio][Checkbox] Add size="small" support #18688
Conversation
@material-ui/core: parsed: +0.10% , gzip: +0.07% Details of bundle changes.Comparing: e8703bf...3ebeb50
|
@SandraMarcelaHerreraArriaga Thanks, it's a good start, I have pushed some commits so you can actually what was missing. I believe the Radio component is more or less covered. What do you think of applying the same method to the Checkbox component? :) |
89cd7e6
to
e7ba0c4
Compare
Hey @oliviertassinari thank you very much! and sure, I am going to start working on apply the same method to Checkbox component :) |
Awesome :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and added the size small support to the checkbox. I think that we are good to merge.
@SandraMarcelaHerreraArriaga Thank you |
@oliviertassinari Ohh thank you, I will take another issue, there is other that you can recommend to me ? |
I would recommend to work on pain points you have personally faced. Otherwise, maybe something you think that is important? |
@oliviertassinari I have commented on some issues to work on it, thank you |
I'm still working on add size= "small" support issue
Closes #18479