Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Don't force a remote when listing prettier changes #18794

Merged
merged 8 commits into from
Dec 27, 2019
Merged

[core] Don't force a remote when listing prettier changes #18794

merged 8 commits into from
Dec 27, 2019

Commits on Dec 11, 2019

  1. [scripts] prettier: don't force a remote when listing changes 

    My master branch is tracking upstream/master, where upstream points to https://github.com/mui-org/material-ui.git
My origin/master is so far behind it breaks the `yarn prettier` command for me (stdout overflow).
I propose to explictly remove the remote.
Like in the script this one is based on: https://github.com/facebook/react/blob/b87aabdfe1b7461e7331abb3601d9e6bb27544bc/scripts/shared/listChangedFiles.js#L29
    @Janpot
    Janpot committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    3db49a5 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. test prettier in ci

    @Janpot
    Janpot committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    33267e5 View commit details
    Browse the repository at this point in the history

  2. with upstream/master?

    @Janpot
    Janpot committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    f809c1c View commit details
    Browse the repository at this point in the history

  3. with origin/master?

    @Janpot
    Janpot committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    3e24ac1 View commit details
    Browse the repository at this point in the history

  4. Maybe conditionally?

    @Janpot
    Janpot committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    ef67d8a View commit details
    Browse the repository at this point in the history

  5. after prettier

    @Janpot
    Janpot committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    dc42520 View commit details
    Browse the repository at this point in the history

  6. add a test for listChangedFiles

    @Janpot
    Janpot committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    a0d43b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Merge branch 'master' into tracked-branch

    @Janpot
    Janpot committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    4821a88 View commit details
    Browse the repository at this point in the history