Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Simplify MiniDrawer demo #18814

Merged
merged 2 commits into from
Dec 13, 2019
Merged

[docs] Simplify MiniDrawer demo #18814

merged 2 commits into from
Dec 13, 2019

Conversation

shc023
Copy link
Contributor

@shc023 shc023 commented Dec 13, 2019 •
edited
Loading

For the minified drawer, open needs to always be true, otherwise the Paper inside gets hidden programmatically.

@shc023
Update MiniDrawer.js
004f577 
For the minified drawer, `open` needs to always be `true`, otherwise the `Paper` inside gets hidden programmatically.
@shc023 shc023 changed the title Update MiniDrawer.js Update MiniDrawer.js doc Dec 13, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 13, 2019 •
edited
Loading

No bundle size changes comparing 3bbc68d...49ec228

Generated by 🚫 dangerJS against 49ec228

@oliviertassinari oliviertassinari changed the title Update MiniDrawer.js doc [docs] Simplify MiniDrawer demo Dec 13, 2019
@oliviertassinari oliviertassinari added component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation PR: ready to ship labels Dec 13, 2019
oliviertassinari
oliviertassinari reviewed Dec 13, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks, this prop is dead with the permanent variant. We can remove it :).

@oliviertassinari oliviertassinari merged commit e8d5e51 into mui:master Dec 13, 2019
@oliviertassinari
Copy link
Member

Thanks for raising this detail.

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shc023 @mui-pr-bot @oliviertassinari