[Docs] Reset the scroll at the top when routing #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing route, we set the scroll at the top of the page See the react-router doc: > In 0.13.x we had a couple of implementations to restore scroll position, we've realized that we can build a better implementation on top of the router and will be doing that very soon, before the 1.0 final release, but it doesn't need to be baked into routing like it was before
oliviertassinari
changed the title
oliviertassinari
added a commit
that referenced
this pull request
Oct 19, 2015
[Docs] Reset the scroll at the top when routing
shaurya947
added a commit
that referenced
this pull request
Oct 21, 2015
Squashed all revert commits into this single one for cleaner history Revert "Merge pull request #1919 from cgestes/master" This reverts commit 85d57da, reversing changes made to 26141b0. Revert "Merge pull request #1904 from oliviertassinari/docs-scroll" This reverts commit e754e0f, reversing changes made to 7943e16. Revert "Merge pull request #1913 from tomasztomys/feature/react-v0.14-support-grid-list" This reverts commit 7943e16, reversing changes made to d310459. Revert "Merge pull request #1916 from shaurya947/react-14-route-hotfix" This reverts commit 02e28f3, reversing changes made to 1e0a4a5. Conflicts: docs/src/app/components/mobile-tear-sheet.jsx Revert "Merge pull request #1884 from callemall/react-0.14-support" This reverts commit fa4a019, reversing changes made to 8819be8. Conflicts: docs/package.json docs/src/app/app.jsx docs/src/app/components/code-example/code-block.jsx docs/src/app/components/pages/components/tabs.jsx docs/src/app/components/pages/customization.jsx docs/src/app/components/pages/get-started.jsx docs/src/app/components/pages/page-with-nav.jsx package.json src/date-picker/date-picker-dialog.jsx src/slider.jsx Cleaning up some dependency issues and missed merge conflicts
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* [docs] Fix DatePicker of 'Customization' section The DatePicker of 'Customization' section is broken. https://next.material-ui-pickers.dev/demo/datepicker#customization * Only rename argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing route, we set the scroll at the top of the page. This was the default behavior before react-router v1.0.0.
See the react-router doc: