-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Document how to disable chrome autofill #19126
Conversation
including the recommendation from mui#18556 in the docs.
No bundle size changes comparing e5b2e22...e1e2485 |
Is this the only approach that worked for you? I'm particularly interested in the new-password approach as well as the fixed id, that doesn't indicate the nature of the field, e.g. |
Co-Authored-By: Matt <github@nospam.33m.co>
I'm now realizing that my struggles with autofill stem from the fact that I was using an older version of the It looks like replacing the I wonder if chrome made an update on their end to fix the prior behavior because this doesn't explain some of the behavior mentioned in #18556 (although I can't find anything in the release notes). I'm now using the component as such:
|
@goleary So it wasn't the autofill but the autocomplete feature of Chrome you were having an issue with. In this case, we can't take what you have experienced into account. You can find a close issue in the history the described it, and that we have fixed in the latest version. I think that that we should go with #18556 (comment), and likely describe what "autofill" refers to. Would that work for you? :) |
I'm not sure I understand the distinction between "autofill" and "autocomplete". Also when I look in chrome settings I see this: None of these three options above seems responsible for the functionality that interferes with my Also because I haven't used the method you mention ( When I pass no I don't have a problem with your addition to the documentation but I think the PR should come from someone that understands why and what they are doing and that's not me :( |
@goleary I think that you are in a good position to make the changes, you are facing the autofill/autocomplete problem that many others will also be unfamiliar with. I think that we could give a shot to this limitation, explaining what we know (I did test the proposed fixes) and iterate, based on it. |
@goleary I would love to get your feedback on the proposed alternative wording. I have used your feedback to tailor it, so thanks for it. |
103905f
to
e1e2485
Compare
Your suggestion looks good to me, I'll be away from my computer till Monday so can't do anything else till then. |
Thanks for having a look :) |
including the recommendation from #18556 in the docs.
Closes #18556