Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix broken TypeScript hash link in CONTRIBUTING.md #19236

Merged
merged 2 commits into from
Jan 15, 2020
Merged

[docs] Fix broken TypeScript hash link in CONTRIBUTING.md #19236

merged 2 commits into from
Jan 15, 2020

Conversation

hiteshkundal
Copy link
Contributor

Resolves #18337

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 14, 2020 •
edited
Loading

No bundle size changes comparing 341d0f3...c3a603e

Generated by 🚫 dangerJS against c3a603e

@mbrookes mbrookes added the docs Improvements or additions to the documentation label Jan 14, 2020
@oliviertassinari oliviertassinari changed the title [docs]: Remove typescript demo link from CONTRIBUTING.md [docs] Fix broken TypeScript hash link in CONTRIBUTING.md Jan 14, 2020
oliviertassinari
oliviertassinari approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can link the new section that brings a bit more detail on the matter.

@oliviertassinari oliviertassinari merged commit c8d9df0 into mui:master Jan 15, 2020
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
Merged
This was referenced Mar 20, 2020
Merged
Merged
This was referenced Apr 6, 2020
Open
Closed
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mbrookes mbrookes mbrookes approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] TypeScript demos link in CONTRIBUTING.md is broken
4 participants
@hiteshkundal @mui-pr-bot @mbrookes @oliviertassinari