Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use reasonable unitless line-height for Box #19260

Merged
merged 3 commits into from
Jan 16, 2020
Merged

[docs] Use reasonable unitless line-height for Box #19260

merged 3 commits into from
Jan 16, 2020
+4 −4

Commits on Jan 16, 2020

  1. [docs] Line height property does not set px units 

    The official docs currently appear like so:

<img width="847" alt="Screen Shot 2020-01-16 at 14 46 03" src="https://user-images.githubusercontent.com/364725/72497140-13a00180-386f-11ea-9927-edc7d016a268.png">

However, using the lineHeight property does not set the unit to "px" in the generated css rule.

<img width="922" alt="Screen Shot 2020-01-16 at 14 50 18" src="https://user-images.githubusercontent.com/364725/72497315-87daa500-386f-11ea-8506-38a70da70eb8.png">

Assuming this is the correct action for the property, the docs should reflect the final state rather than the misleading "10px" label which currently exists.
    @minikomi
    minikomi committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    4a32619 View commit details
    Browse the repository at this point in the history

  2. transpile tsx

    Adam Moore committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    fd8d0f9 View commit details
    Browse the repository at this point in the history

  3. Use 2 instead of 10 on line height example

    Adam Moore committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b872a1a View commit details
    Browse the repository at this point in the history