[docs] Improve draggable dialog demo #19339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 2082679...31792e6 |
|
Thanks for working on this. Could you apply the same patch to the |
konekoya
force-pushed
the
dialog-handle
branch
from
8c745d8
to
31792e6
Compare
oliviertassinari
added
the
component: dialog
Thanks for the help @eps1lon! The PR has been updated and everything is passing :) |
|
@konekoya Nice catch, thanks. |
No problem! Thanks for the review :) |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Jan 23, 2020
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're explicitly setting
style={{ cursor: 'move' }}in theDialogTitle. We should also make sure only the title is "draggle", not the whole dialog.