Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Add Catalan (ca-ES) locale #19428

Merged
merged 10 commits into from
Jan 28, 2020
Merged

[l10n] Add Catalan (ca-ES) locale #19428

merged 10 commits into from
Jan 28, 2020

Conversation

yyuri
Copy link
Contributor

@yyuri yyuri commented Jan 27, 2020

Added Catalan (ca_ES) locale and translation

Added Catalan (ca_ES) locale and translation
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 27, 2020

No bundle size changes comparing f649826...da00af4

Generated by 🚫 dangerJS against da00af4

@mbrookes mbrookes added the core Infrastructure work going on behind the scenes label Jan 27, 2020
@mbrookes mbrookes changed the title Added Catalan (ca_ES) translation Add Catalan (ca_ES) translation Jan 27, 2020
@oliviertassinari oliviertassinari added the new feature New feature or request label Jan 27, 2020
@oliviertassinari oliviertassinari changed the title Add Catalan (ca_ES) translation [l10n] Add Catalan (ca_ES) locale Jan 27, 2020
@oliviertassinari
Copy link
Member

@yyuri thanks for the contribution. Do you think that you could update the documentation part as well? :)

@yyuri
Copy link
Contributor Author

yyuri commented Jan 28, 2020

Np, thanks for your work.
Opened a new pull with the Catalan translations of the docs:
#19441

@oliviertassinari
Copy link
Member

@yyuri I'm so sorry, I should have been more explicit! I had this in mind: https://github.com/mui-org/material-ui/pull/19439/files.

@yyuri
Copy link
Contributor Author

yyuri commented Jan 28, 2020

Np, commited all mentioned files, hope this is it

@oliviertassinari
Copy link
Member

@yyuri Please, let's keep the changes on a single pull-request, here :)

@yyuri
Copy link
Contributor Author

yyuri commented Jan 28, 2020

Done, sorry for the mess of pulls

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for polishing it up :)

@oliviertassinari oliviertassinari changed the title [l10n] Add Catalan (ca_ES) locale [l10n] Add Catalan (ca-ES) locale Jan 28, 2020
@oliviertassinari oliviertassinari merged commit 328c73a into mui:master Jan 28, 2020
@oliviertassinari
Copy link
Member

@yyuri Thank you, don't worry about the extra commits :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants