-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve Style Library Interoperability #19457
[docs] Improve Style Library Interoperability #19457
Conversation
No bundle size changes comparing 5c84559...92473e2 |
30d41f0
to
b299dc9
Compare
b299dc9
to
695cb3f
Compare
diff --git a/docs/src/pages/guides/interoperability/interoperability.md b/docs/src/pages/guides/interoperability/interoperability.md
index 825a80439..00691ab0b 100644
--- a/docs/src/pages/guides/interoperability/interoperability.md
+++ b/docs/src/pages/guides/interoperability/interoperability.md
@@ -15,7 +15,7 @@ There are examples for the following styling solutions:
## Plain CSS
-Nothing fancy, plain old CSS.
+Nothing fancy, just plain old CSS.
**PlainCssButton.css**
```css Not sure why someone would have chosen to break the grammar. 😉 (But you could drop "old" if it's too colloquial.) |
One concern with the new customization example is that it looks very similar to a standard contained button. I don't have a good suggestion for an alternative though, sorry. |
@mbrookes Thanks, I have added just and removed old.
I haven't thought about it. What if we could consider the button is an excuse to cover the interoperability material? |
When this was merged it erased the React JSS section at the bottom of the page. The React JSS link is still at the top, but it clicking it links/navigates to nowhere. Was this on purpose or a mistake maybe? Here is the live page: |
@johnwils The example wasn't working correctly. However, I think that we should introduce it back. Do you want to work on it? :) |
@oliviertassinari oh. i reread the top comment and missed this part: Remove react-jss from the list, the example is broken, and given stats are going down: https://npm-stat.com/charts.html?package=react-jss, I would rather not invest time on fixing it. sorry i don’t have time atm. But have a question :-) Does the stars going down.. reflect on the future of material-ui api makeStyles? It uses react-jss. curious if @material-ui/styles may move in another direction or stick to makeStyles in future versions |
I have tried to improve our style interoperability guide. Here are a couple of leverages I have explored:
Stuff we should cover later on: How to use the theme object with SASS and CSS modules? https://github.com/MadLittleMods/postcss-css-variables#preserveinjectedvariables-default-true
I can't wait for Material-UI supporting styled-components and emotion, it's going to be awesome 😍 !