Alias onClick to onTouchTap for ListItem right button/icon. #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have had a lot of issues with initializeTapEventsPlugin when trying to build a Material-UI project with Webpack using React as an external. The way the tap event plugin is injected just does not work with an external React. This may be more widespread (in other components) but our biggest pain point right now is not being able to expand nested list items. Is there a problem with aliasing onClick to onTouchTap for those who might not be able to handle touch events or those that have an issue with the initializeTapEvents plugin and Webpack externals?
hartmamt
changed the title
|
Work around for this issue... Quick webpack example of how to patch react-with-addons with the tap events plugin. This is required as far as I can tell if you want to use material-ui with react as an external dependency. https://github.com/hartmamt/react-with-tap-events |
|
Closing this issue. I prefer my workaround which is actually a real solution to the problem...it isn't material-ui's fault that this is happening. |
|
Yes. There is an open ticket here. zilverline/react-tap-event-plugin#22. Definitely not a material-ui issue. |
|
Ok thanks. |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
zannager
added
the
component: button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a lot of issues with initializeTapEventsPlugin when trying to build a Material-UI project with Webpack using React as an external. The way the tap event plugin is injected just does not work with an external React. This may be more widespread (in other components) but our biggest pain point right now is not being able to expand nested list items. Is there a problem with aliasing onClick to onTouchTap for those who might not be able to handle touch events or those that have an issue with the initializeTapEvents plugin and Webpack externals?