Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker] inline property for none dialog picker #1977

Closed
wants to merge 2 commits into from
Closed

[DatePicker] inline property for none dialog picker #1977

wants to merge 2 commits into from

Conversation

tyfoo
Copy link
Contributor

@tyfoo tyfoo commented Oct 23, 2015

Inline DatePicker, supports the same API as the default DatePicker (dialog)

<DatePicker inline={true} autoOk={true} />

Implements #1822

@otroboe
Copy link

otroboe commented Oct 27, 2015

👍

@oliviertassinari
Copy link
Member

@tyfoo Thanks for this PR. I think that an inlined DatePicker as TimerPicker would be a good feature. What do you think about using #2043 to do so?

@oliviertassinari oliviertassinari mentioned this pull request Nov 4, 2015
Closed
@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed Review: review-needed labels Nov 4, 2015
@tyfoo
Copy link
Contributor Author

tyfoo commented Nov 6, 2015

@oliviertassinari Sure. I don't mind using the Popover, but does that mean I need to wait for #2043 to be merged?

May I suggest using both options, i.e. inline and popover? I'll be happy to make any changes needed.

@oliviertassinari oliviertassinari added Review: review-needed and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Nov 6, 2015
@oliviertassinari
Copy link
Member

May I suggest using both options, i.e. inline and popover? I'll be happy to make any changes needed.

Sounds like a good idea, inline would be the same thing without animation.

oliviertassinari
oliviertassinari reviewed Nov 8, 2015
View reviewed changes
src/date-picker/date-picker-dialog.jsx
@@ -44,6 +45,7 @@ const DatePickerDialog = React.createClass({
wordings: React.PropTypes.object,
disableYearSelection: React.PropTypes.bool,
initialDate: React.PropTypes.object,
inline: React.PropTypes.bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the default value to getDefaultProps?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not use a bool type, since we may add the popover container. Maybe we should call this property container with a value between:

  • dialog (default)
  • inline
  • soon popover

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed Review: review-needed labels Nov 8, 2015
@tyfoo
Copy link
Contributor Author

tyfoo commented Nov 8, 2015

@oliviertassinari Thanks for all your feedback and suggestions. I've made the changes needed (to prepare for Popover) and amended my last commit.

Please let me know if there is anything else I can do.

oliviertassinari
oliviertassinari reviewed Nov 9, 2015
View reviewed changes
src/date-picker/date-picker-inline.jsx
zIndex: 100,
width: '100%',
position: 'relative',
display: (open === true ? 'block' : 'none'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the display property, why not doing in the render method?
This would prevent to render the Calander when it's hidden. Though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea. I'll make the needed changes.

@oliviertassinari
Copy link
Member

@tyfoo We are almost there 😄 .

@tyfoo
Copy link
Contributor Author

tyfoo commented Nov 9, 2015

@oliviertassinari Thanks again for your feedback and suggestions. I've made the changes and amended my last commit. Let me know if you have any other thoughts or changes you'd like me to do.

@oliviertassinari
Copy link
Member

@tyfoo We have updated the DatePicker to use the new Dialog API. This add some conflict with your PR. Sorry. (This should be straightforward to resolve)

@tyfoo
Squashed commit of the following:
12aba3e 
commit 615c4eb
Merge: 48912d6 26a0c85
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 10 10:27:00 2015 +0100

    Merge pull request mui#2091 from callemall/oliviertassinari-patch-1

    [eslint] Use the latest version

commit 48912d6
Merge: 6f28ad0 5b4c559
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 10 10:16:55 2015 +0100

    Merge pull request mui#2116 from subjectix/fix-dialog-raw-code

    Fixed raw code of dialog's open prop

commit 5b4c559
Author: Ali Taheri <ali.taheri.m@gmail.com>
Date:   Tue Nov 10 10:37:26 2015 +0330

    Fixed raw code of dialog's open prop

commit 6f28ad0
Author: Shaurya Arora <shaurya.arora1@gmail.com>
Date:   Mon Nov 9 18:30:22 2015 -0600

    v0.13.2 release

commit fd088e1
Merge: d328658 4145d8f
Author: Shaurya Arora <shaurya.arora1@gmail.com>
Date:   Mon Nov 9 17:42:57 2015 -0600

    Merge pull request mui#2113 from shaurya947/master

    Add import statements to every component's doc page

commit 4145d8f
Author: Shaurya Arora <shaurya.arora1@gmail.com>
Date:   Mon Nov 9 17:32:18 2015 -0600

    Add import statements to every component's doc page

commit d328658
Merge: abfd6ae a8066d1
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 10 00:16:14 2015 +0100

    Merge pull request mui#2112 from callemall/oliviertassinari-patch-3

    [npm] Add private: true

commit a8066d1
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 10 00:12:13 2015 +0100

    Update package.json

    Add private to the docs package.json.
    Will prevent this warning to be displayed `npm WARN package.json material-ui-docs@0.13.1 No license field.`
    and accidental publish.

commit abfd6ae
Merge: 7233878 ed062ff
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 10 00:06:28 2015 +0100

    Merge pull request mui#2111 from luisrudge/remove-peer-dependencies

    [npm] moving some peer dependencies to dependencies

commit ed062ff
Author: Luis Rudge <luis@luisrudge.net>
Date:   Mon Nov 9 20:30:29 2015 -0200

    moving some peer dependencies to dependencies

commit 7233878
Merge: 49feb2e 915c1eb
Author: Shaurya Arora <shaurya.arora1@gmail.com>
Date:   Mon Nov 9 15:52:36 2015 -0600

    Merge pull request mui#2105 from oliviertassinari/open

    [Dialog] Use open instead of isOpen

commit 915c1eb
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Mon Nov 9 19:07:13 2015 +0100

    [Dialog] Use open instead of isOpen

commit 49feb2e
Merge: bb57b9f 6aff277
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Mon Nov 9 13:05:23 2015 +0100

    Merge pull request mui#2044 from CalebEverett/master

    [LeftNav] Open or close if docked prop changes when window resizes

commit bb57b9f
Merge: e439aaa bc7ceac
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Mon Nov 9 13:00:34 2015 +0100

    Merge pull request mui#2045 from rhythnic/master

    [Badge] Add a new component

commit bc7ceac
Author: Nick Baroni <nick@rhythnic.com>
Date:   Tue Nov 3 17:49:19 2015 +0900

    Added badge component.

commit e439aaa
Merge: c78b437 22e3b4c
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Mon Nov 9 11:37:23 2015 +0100

    Merge pull request mui#2097 from callemall/oliviertassinari-patch-2

    [README] Use master branch for the travis build status

commit 22e3b4c
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Mon Nov 9 11:12:46 2015 +0100

    [README] Use master branch for the travis build status

commit 6aff277
Author: Caleb Everett <caleb@careercalifornia.edu>
Date:   Wed Nov 4 12:20:53 2015 -0800

    set LeftNav docked in componentWillReceiveProps

commit 26a0c85
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sun Nov 8 15:51:53 2015 +0100

    [eslint] Use the latest version

commit c78b437
Merge: df5f6ed 0dc2e4a
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sun Nov 8 13:29:41 2015 +0100

    Merge pull request mui#2083 from subjectix/dialog-style-prop

    [doc] Add style property

commit df5f6ed
Merge: b4f8f8a 230bfcf
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sun Nov 8 12:22:30 2015 +0100

    Merge pull request mui#2084 from oliviertassinari/npm

    [npm] Separate the lint and the build

commit 230bfcf
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Sat Nov 7 12:54:20 2015 +0100

    [npm] Separate the lint and the build

commit 0dc2e4a
Author: Ali Taheri <ali.taheri.m@gmail.com>
Date:   Tue Oct 6 15:54:45 2015 +0330

    Added undocumented style property to the components that use it

commit b4f8f8a
Merge: 780d9a5 34e26fb
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sat Nov 7 04:03:50 2015 +0100

    Merge pull request mui#2078 from EnzoMartin/patch-1

    Fix label display with Chrome autocomplete

commit 780d9a5
Merge: 4ab4d19 dfa9216
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sat Nov 7 02:44:05 2015 +0100

    Merge pull request mui#2073 from quangbuule/patch-1

    [TextField] Fix isValid function

commit 34e26fb
Author: Enzo Martin <enzo.r.martin@gmail.com>
Date:   Fri Nov 6 19:12:22 2015 +0100

    Fix label display with Chrome autocomplete

commit 4ab4d19
Merge: 47bf496 9fc0926
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Fri Nov 6 18:01:53 2015 +0100

    Merge pull request mui#2070 from mbrookes/patch-1

    [Doc] Add missing Textfield docs

commit 9fc0926
Author: Matt Brookes <mbrookes@users.noreply.github.com>
Date:   Fri Nov 6 16:34:44 2015 +0000

    Correct prop name!

commit dfa9216
Author: Quangbuu Le <quangbuule@gmail.com>
Date:   Fri Nov 6 11:29:25 2015 +0700

    Update text-field.jsx

    The isValid function return not correct, this caused re-rendering the whole TextField when value prop received.

commit 0904107
Author: Matt Brookes <mbrookes@users.noreply.github.com>
Date:   Thu Nov 5 23:08:41 2015 +0000

    Missing Textfield docs.

commit 47bf496
Merge: 7df3a99 2b1e062
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Thu Nov 5 15:22:32 2015 +0100

    Merge pull request mui#2063 from pandaiolo/node-props

    Changing propType from string to node on components

commit 2b1e062
Author: Pandaiolo <aurelien@arimaska.net>
Date:   Thu Nov 5 14:30:04 2015 +0100

    [docs] Changing propType from string to node on components

commit 98532fd
Author: Pandaiolo <aurelien@arimaska.net>
Date:   Thu Nov 5 12:53:38 2015 +0100

    Changing propType from string to node on components

commit 7df3a99
Merge: 789eaee 2019ad9
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Thu Nov 5 11:36:11 2015 +0100

    Merge pull request mui#2062 from pinturic/patch-1

    [LeftNav] Fix resize when using children

commit 2019ad9
Author: pinturic <luca.tagliaferri@gmail.com>
Date:   Thu Nov 5 11:28:04 2015 +0100

    Update left-nav.jsx

    cleaned _updateMenuHeight variables declaration

commit b6cca6f
Author: pinturic <luca.tagliaferri@gmail.com>
Date:   Thu Nov 5 11:14:27 2015 +0100

    Update left-nav.jsx

    Menu can be null if the MenuItems are inlined

commit 789eaee
Merge: 8f5510a 308a7a2
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Wed Nov 4 23:56:20 2015 +0100

    Merge pull request mui#2016 from KapJI/theme-fix

    [Theme] Fix Slider and Toggle colors

commit 8f5510a
Merge: dfb8363 801e05a
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Wed Nov 4 23:13:54 2015 +0100

    Merge pull request mui#1996 from JorgenEvens/feature/dialog-show-prop

    [Dialog] Allow open state of dialog to be controlled through the show prop

commit 801e05a
Author: Jorgen Evens <jorgen@evens.eu>
Date:   Thu Oct 29 20:26:37 2015 +0100

    [Dialog] Re-enable legacy API with deprecation warnings.

commit 8050f49
Author: Jorgen Evens <jorgen@evens.eu>
Date:   Tue Oct 27 22:48:45 2015 +0100

    [Dialog] Switch from imperative control to props.

    - Remove .dismiss() and .show()
    - Remove onShow and onDismiss callback
    - Added onRequestClose callback
    - Removed modal property
    - Updated docs
    - Add default values for defaultIsOpen and isOpen.

commit dfb8363
Merge: aef950e 045b630
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Wed Nov 4 18:43:13 2015 +0100

    Merge pull request mui#2054 from cannium/master

    [TableBody] Table click away should also trigger onRowSelection

commit 045b630
Author: Can Zhang <zhangcan@letv.com>
Date:   Wed Nov 4 10:36:22 2015 +0800

    Table click away should also trigger onRowSelection

commit aef950e
Merge: d3ee052 e7d6660
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 3 19:33:29 2015 +0100

    Merge pull request mui#2051 from chrismcv/auto-prefix-null

    [AutoPrefix] add null support

commit d3ee052
Merge: 67cca09 d14c413
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 3 19:16:40 2015 +0100

    Merge pull request mui#2049 from Dashlane/fix/typo-textfield-doc

    [Doc] Fix typo in TextField doc

commit d14c413
Author: Thomas Guillory <thomas.guillory@dashlane.com>
Date:   Tue Nov 3 10:50:59 2015 +0100

    Fix typo in TextField doc

    There is a typo in TextField element documentation: the "Style Hint
    Text" example is not using the right property of `styles` object.

commit e7d6660
Author: Chris McVittie <chris.mcvittie@blue-zinc.com>
Date:   Tue Nov 3 16:25:52 2015 +0000

    auto prefix null support

commit 67cca09
Merge: 5821f0a dfb0acb
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 3 17:04:18 2015 +0100

    Merge pull request mui#1720 from NatalieT/ipad-fix

    [TextField fix ipad enhanced textarea

commit dfb0acb
Author: Natalie Fitzsimons <natalie.fitzsimons@tm2app.co.uk>
Date:   Tue Nov 3 15:23:00 2015 +0000

    ipad cursor in extra field fix

commit 5821f0a
Merge: c8e622e 50a0942
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 3 14:47:55 2015 +0100

    Merge pull request mui#2042 from chrismcv/r2l

    Render to Layer component

commit 50a0942
Author: Chris McVittie <chris@greenflump.com>
Date:   Mon Nov 2 20:35:40 2015 +0000

    Render to Layer component (+ squashed fixes)

commit c8e622e
Merge: 08a7c6b 3983146
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 3 12:07:44 2015 +0100

    Merge pull request mui#2014 from oliviertassinari/button-label-position

    [Button] Fix and add missing labelPosition

commit 08a7c6b
Merge: 076c4af bfa7336
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 3 12:06:52 2015 +0100

    Merge pull request mui#2024 from oliviertassinari/snackbar-fix-hide-show

    [Snackbar] Assert that displayed data changed before hide/show

commit 076c4af
Merge: ac357ec 7677be5
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Tue Nov 3 11:58:29 2015 +0100

    Merge pull request mui#2047 from oliviertassinari/fix-progress

    [CircularProgress] Fix transition

commit 7677be5
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Tue Nov 3 11:50:19 2015 +0100

    [CircularProgress] clean up

commit 3f6d31a
Author: Chris McVittie <chris@greenflump.com>
Date:   Mon Nov 2 19:45:57 2015 +0000

    fix circular progress issue

commit ac357ec
Merge: 68baf9b b12bcdd
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sun Nov 1 20:15:40 2015 +0100

    Merge pull request mui#2007 from Cavitt/universal-rendering

    Universal Rendering Support

commit b12bcdd
Author: Cavitt <support@xenomap.com>
Date:   Thu Oct 29 06:01:27 2015 -0500

    Implemented inline-style-prefixer

    User agent based prefixing for client and server side rendering. When
    rendering server-side define `navigator.userAgent` after receiving
    request headers but before rendering styles. A warning will be shown
    when attempting to use server-side rendering without defining a user
    agent. Client side rendering should automatically work as all modern
    browsers provide user agent via the navigator property.

commit 68baf9b
Merge: edaf30f b13fe11
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sun Nov 1 16:49:36 2015 +0100

    Merge pull request mui#2025 from CameronFletcher92/timepicker-fix

    Added keys to timepicker buttons, fixed mui#1964

commit edaf30f
Merge: c66ff3d f25ef9e
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sun Nov 1 16:46:11 2015 +0100

    Merge pull request mui#2030 from CameronFletcher92/tableheader-fix

    [Table] Added key to selectall column in TableHeader. Addresses mui#2028

commit f25ef9e
Author: Cameron Fletcher <cameronfletcher92@gmail.com>
Date:   Sun Nov 1 15:06:04 2015 +1000

    removed console log

commit 0b57d95
Author: Cameron Fletcher <cameronfletcher92@gmail.com>
Date:   Sun Nov 1 15:02:18 2015 +1000

    [Table] Added key to selectall column in TableHeader. Addresses mui#2028

commit c66ff3d
Merge: 0d86eea 80141f6
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sun Nov 1 00:51:10 2015 +0100

    Merge pull request mui#2021 from callemall/oliviertassinari-patch-1

    [Overlay] Fix server side rendering

commit b13fe11
Author: Cameron Fletcher <cameronfletcher92@gmail.com>
Date:   Sun Nov 1 00:24:16 2015 +1000

    changed timepicker button keys to AM/PM

commit e3920ac
Author: Cameron Fletcher <cameronfletcher92@gmail.com>
Date:   Sun Nov 1 00:14:17 2015 +1000

    Added keys to timepicker buttons, fixed mui#1964

commit bfa7336
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Sat Oct 31 12:28:17 2015 +0100

    [Snackbar] Assert that displayed data changed before hide/show

commit 0d86eea
Merge: 6141e2b 176762e
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sat Oct 31 12:22:26 2015 +0100

    Merge pull request mui#2022 from oliviertassinari/fix-test-date-picker

    [DatePicker] Fix tests for the 31 of October

commit 176762e
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Sat Oct 31 12:03:05 2015 +0100

    [DatePicker] Fix tests for the 31 of October

    This is a temporary fix.
    There is an edge case with the test.
    Calling addMonths with 31 of October return 1 of December,
    while we expect November.

commit 80141f6
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sat Oct 31 11:16:39 2015 +0100

    [Overlay] Fix server side rendering

    The componentDidMount method is not called when rendering server side

commit 6141e2b
Merge: fd346dd 3f8825f
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Sat Oct 31 11:11:49 2015 +0100

    Merge pull request mui#1609 from umidbekkarimov/master

    [Table] onRowSelection return 'none' string on unselect all

commit 3983146
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Fri Oct 30 13:39:33 2015 +0100

    [Button] Fix and add missing labelPosition

commit fd346dd
Merge: 9be7261 a3e9cad
Author: Shaurya Arora <shaurya.arora1@gmail.com>
Date:   Fri Oct 30 17:03:23 2015 -0500

    Merge pull request mui#1589 from KapJI/slider-minvalue

    [Slider] Remove redundant 'defaultValue'. Fix bug when 'min' is greater than zero.

commit 308a7a2
Author: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
Date:   Fri Oct 30 20:54:27 2015 +0300

    Fix Slider and Toggle colors

commit a3e9cad
Author: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
Date:   Fri Oct 30 19:35:44 2015 +0300

    [Slider] Return 'defaultValue' back

commit 9be7261
Merge: 3304889 f69ad2d
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Thu Oct 29 22:34:34 2015 +0100

    Merge pull request mui#1907 from oliviertassinari/tabs-swipeable

    [Docs] Add an example of tabs with a slide effect

commit f69ad2d
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Sat Oct 17 01:05:22 2015 +0200

    [Docs] Add an example of tabs with a slide effect

    This a classical use case for tabs on android.

commit 3304889
Author: Shaurya Arora <shaurya.arora1@gmail.com>
Date:   Thu Oct 29 16:08:34 2015 -0500

    V0.13.1 release

commit 02959ea
Merge: eb3d232 8aaa223
Author: Olivier Tassinari <Olivier.tassinari@gmail.com>
Date:   Thu Oct 29 10:51:14 2015 +0100

    Merge pull request mui#1988 from igorbt/gridlist-docs-fix

    [GridList] docs fix - add back code examples

commit 8aaa223
Author: igorbt <igorbt@yahoo.com>
Date:   Wed Oct 28 06:28:43 2015 +0200

    fixed warning about keys and style

commit 6e93319
Author: igorbt <igorbt@yahoo.com>
Date:   Thu Oct 22 07:33:24 2015 +0300

    adding back grid-list code examples

commit 28a0477
Author: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
Date:   Fri Sep 4 18:48:19 2015 +0300

    Fix value update while dragging

commit 29964f5
Author: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
Date:   Fri Sep 4 00:39:48 2015 +0300

    Remove redundant 'defaultValue'. Fix bug when 'min' greater than zero.

commit 3f8825f
Author: Umidbek Karimov <uma.karimov@gmail.com>
Date:   Tue Sep 8 18:02:54 2015 +0500

    Update table.jsx

    [Table] onRowSelection return 'none' string on unselect all
@tyfoo
Copy link
Contributor Author

tyfoo commented Nov 10, 2015

@oliviertassinari Thank you. I have merged + squashed from master. This PR should be ready to merge, but let me know if there is anything I need to do.

@oliviertassinari
Copy link
Member

@tyfoo The diff is weird: +1,819 −542

@tyfoo
Copy link
Contributor Author

tyfoo commented Nov 10, 2015

@oliviertassinari I rebased from master and squashed the commits. I can undo my last commit (the merge), but what should I do differently this time? Any suggestions?

@oliviertassinari oliviertassinari mentioned this pull request Nov 10, 2015
Merged
@oliviertassinari
Copy link
Member

@tyfoo Thanks for this, I'm on it 👍

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@oliviertassinari
[core] Update examples formatting to match main v2 (mui#1977)
5cce569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyfoo @otroboe @oliviertassinari