-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooltip] Fix useMemo dependency #19899
Conversation
`deepmerge` supports `null` and `undefined` source, no need to default to an empty object. This is a follow-up to #19851.
Details of bundle changes.Comparing: b9dec27...ea4fa57
|
I doubt we can write a test for this, unfortunately. |
Strictly speaking, I could with mocks (or Enzyme and |
Thanks for the patch |
deepmerge
supportsnull
andundefined
source,no need to default to an empty object.
This is a follow-up to #19851.
That being said, if
PopperProps
is defined inline in user land, it would bust the cache all the time, so not sure how usefuluseMemo
is. Unless we expect users to also memoisePopperProps
🤷♂️