-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Skeleton] Improve wave dark mode support #20112
[Skeleton] Improve wave dark mode support #20112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you reverse the images? "Before" has higher contrast. This should be preferred IMO.
@eps1lon I think that the visual accessibility of the Skeleton should be completely ignored. The component targets users with good visual capabilities in the first place. |
Why would you exclude some people? Am I only allowed to orient myself in a perfectly light environment with perfect vision? |
I believe there is a tradeoff to find between how much contrast the element has and how good it "feels". The more contrast, the "uglier" it becomes. I have slithy increased the contrast. |
Well I disagree. It's ugly regardless of the contrast since it's just a block. But the purpose of it is that users can orient themselves. Not to act as decoration. |
This reverts commit a530f7f.
Details of bundle changes.Comparing: eb1529f...e97ff40 Details of page changes
|
I have reverted that last commit, it looked better will less contrast. I think that the take away is that this animation isn't very important. It's better to have it only visible in great contrast conditions (for people that start to wonder if the app hasn't frozen) than something that catches the attention for no reason and feels off. |
The new strategy is to double the opacity for the wave animation. It seems to perform better:
Before
After