[docs] Extract landing-only modules #20187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 994dd2a...f23bca0 Details of page changes
|
oliviertassinari
approved these changes
Mar 19, 2020
|
The regression failure is weird. |
|
Error message is pretty useless for this case. I think I have a helper. |
|
@eps1lon 👍 for improving the DX when it fails |
eps1lon
commented
Mar 20, 2020
|
Not marked because we stop retrying too fast. Will increase to 5x after 120s each. |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable whitespace diff for review
I think it's safe to say by now that this is the proper abstraction. src/modules implies that these serve a general purpose but they were never used outside of the landing page