-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch small changes #20255
[core] Batch small changes #20255
Conversation
Details of bundle changes.Comparing: 2f47739...db8de00 Details of page changes
|
a167af8
to
db8de00
Compare
"signUpTitle": "Sign Up", | ||
"signUpDescr": "A simple Sign Up page.", | ||
"blogTitle": "Blog", | ||
"albumDescr": "A responsive album / gallery page layout with a hero unit and footer.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we avoid these in the future please? needless git blame indirection. otherwise add a lint rule to prevent regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if they were some sort of prefixing structure in the translation keys, as I was about to add a new key. I have sorted ASC to figure this point out. It turns out, there is none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not saying that sorting isn't useful. But it's easily forgotten and once every blue moon someone decides to update it 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, it's rarely kept up to date.
createPalette
is private anyway.