-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix blurOnSelect consistency for keyboard #20314
Merged
oliviertassinari
merged 2 commits into
mui:master
from
alexbarkin:blurOnSelect-Autocomplete
Mar 29, 2020
Merged
[Autocomplete] Fix blurOnSelect consistency for keyboard #20314
oliviertassinari
merged 2 commits into
mui:master
from
alexbarkin:blurOnSelect-Autocomplete
Mar 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
Enable blurOnSelect for keyboard input
[Autocomplete] Fix blurOnSelect consistency for keyboard input
Mar 28, 2020
oliviertassinari
changed the title
[Autocomplete] Fix blurOnSelect consistency for keyboard input
[Autocomplete] Fix blurOnSelect consistency for keyboard
Mar 28, 2020
oliviertassinari
added
component: autocomplete
This is the name of the generic UI component, not the React module!
bug 🐛
Something doesn't work
labels
Mar 28, 2020
Details of bundle changes.Comparing: 403a6df...88c9c4a Details of page changes
|
oliviertassinari
approved these changes
Mar 28, 2020
@alexbarkin Thanks, I was wondering about adding a new test case, but I believe the logic is simple enough not to require it. |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 6, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20137
This PR allows blurOnSelect to work when using keyboard input. Prior to this PR, the popup would close, but the input field would not blur.