-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Move Copyright into its own component #20383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
force-pushed
the
nextjs-code-duplication
branch
from
April 2, 2020 08:29
be638dd
to
891922d
Compare
Details of bundle changes.Comparing: 79c6dfd...38d9358 Details of page changes
|
eps1lon
added
docs
Improvements or additions to the documentation
PR: ready to ship
labels
Apr 2, 2020
eps1lon
approved these changes
Apr 2, 2020
What about the other examples? |
oliviertassinari
changed the title
[docs] Next.js: Move Copyright into its own component
[examples] Move Copyright into its own component
Apr 2, 2020
oliviertassinari
force-pushed
the
nextjs-code-duplication
branch
from
April 2, 2020 10:09
891922d
to
166432c
Compare
oliviertassinari
approved these changes
Apr 2, 2020
@HaNdTriX Thanks! |
3 tasks
This was referenced Apr 6, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
examples/nextjs
: Move Copyright into its own componentexamples/nextjs-with-typescript
: Move Copyright into its own componentMotivation
Removes code duplication.
Closes #20385