-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Reset input on blur for freeSolo mode too #20603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Autocomplete in freeSolo mode, editing the field manually (with keyboard) and then blurring the field, make sure the field is reset to its current value. Otherwise, the actual field value does not correspond to the last value used in onChange.
Details of bundle changes.Comparing: fe687bf...d813c79 Details of page changes
|
oliviertassinari
added
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
labels
Apr 17, 2020
@goffioul Thank you :). I don't think that we need a test case here, as we remove one branching that has been around since the early prototyping of the component. If it does introduce a regression, it will be a different story. |
I had forgotten about the history behind this logic. I'm working on a new pull request to restore the previous behavior. |
2 tasks
This was referenced Apr 20, 2020
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Autocomplete in freeSolo mode, editing the field manually
(with keyboard) and then blurring the field, make sure the field is
reset to its current value. Otherwise, the actual field value does not
correspond to the last value used in onChange.
Closes #19423