-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Fix caret color in autofill dark theme #20857
Merged
oliviertassinari
merged 1 commit into
mui:master
from
CarsonF:bugfix/auto-fill-caret-color
May 3, 2020
Merged
[TextField] Fix caret color in autofill dark theme #20857
oliviertassinari
merged 1 commit into
mui:master
from
CarsonF:bugfix/auto-fill-caret-color
May 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 024e176...e84e285 Details of page changes
|
joshwooding
added
the
component: text field
This is the name of the generic UI component, not the React module!
label
May 2, 2020
joshwooding
changed the title
[Input] Update caret color to match autofilled text color with dark theme
[TextField] Update caret color to match autofilled text color with dark theme
May 2, 2020
joshwooding
approved these changes
May 2, 2020
@CarsonF How do you reproduce the issue? |
I clicked the autofill option and then clicked on the text field. |
oliviertassinari
changed the title
[TextField] Update caret color to match autofilled text color with dark theme
[TextField] Fix caret color in autofill dark theme
May 2, 2020
oliviertassinari
approved these changes
May 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, awesome. We can reproduce on https://material-ui.com/getting-started/templates/sign-in/
@CarsonF Thank you! |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: text field
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After