-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Recommend no-restricted-imports to catch treeshake issues #21035
Conversation
docs/src/pages/customization/typography/ResponsiveFontSizesChart.js
Outdated
Show resolved
Hide resolved
Details of bundle changes.Comparing: 0cd1413...66017aa Details of page changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @dmtrKovalenko it seems that copying it isn't required (https://github.com/mui-org/material-ui-pickers/issues/1657#issuecomment-613474960).
docs/src/pages/customization/typography/ResponsiveFontSizesChart.js
Outdated
Show resolved
Hide resolved
@eps1lon The plugin isn't published on npm, should we replace all the labels with "core"? |
Let's deprecate https://www.npmjs.com/package/eslint-plugin-material-ui then. |
docs/src/pages/guides/minimizing-bundle-size/minimizing-bundle-size.md
Outdated
Show resolved
Hide resolved
…-size.md Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Sure. At least, for now, there is no more good reason to install the package. I don't have write access so I can't do it. Arguably, there is very few downloads, "last published 4 years ago" feels like quite deprecated 🙃. |
Yet, we have requests to publish the latest versions. |
I believe this pull request addresses the request 👌, the incentive was to benefit from the restricted import path. |
Drop custom rule in favor of the built-in
no-restricted-imports
rule.