[Tooltip] Add PopperComponent prop #21039
Conversation
joshwooding
added
new feature
Details of bundle changes.Comparing: f63646a...40b2a8b Details of page changes
|
@joshwooding It would be great to have an example, the last time we talk about it. I was leaning toward removing Also, we have frozen all-new feature addition on v4. It would need to be treated as a bug fix. For v5, I think that we will need a way to customize all the used components anyway, so we might wait for this future point in time. |
There was a problem hiding this comment.
Use Case: Using a native popper that displays tooltips in native windows. (I don't know how this part works yet :P)
Did you add a test that illustrates this use case?
Also, we have frozen all-new feature addition on v4. It would need to be treated as a bug fix.
That's not how this works. Either we don't work on features or we do. Re-labeling features as bug fixes does not get us anywhere.
@olivertassinari I know we were thinking of this but has it been confirmed publicly. I haven’t seen anything but might have missed it?
I agree with @eps1lon |
|
@joshwooding There are a couple of open pull requests that are on hold because they introduce new features. I think that we need to this feature freeze on the core to free us time to work on the v5 depreciation warnings. |
joshwooding
force-pushed
the
add-popper-component-prop-to-tooltip
branch
from
8a25a69 to
bb6d6a4
Compare
Allows overriding of Popper in Tooltip like Autocomplete.
Use Case: Using a native popper that displays tooltips in native windows. (I don't know how this part works yet :P) cc @oliviertassinari
Also refactored the tests cc @eps1lon