-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Keep the same header between locales #21041
[docs] Keep the same header between locales #21041
Conversation
Details of bundle changes.Comparing: 758a8ad...409ad02 Details of page changes
|
I can reproduce this with node 10 but not node 14. And if I remember correctly node didn't have a stable I would recommend you partition I pushed a change so that the deploy preview builds all locales. The preview is built with node 10 so we can verify if this is a test or implementation issue. |
@eps1lon Thanks, I was suspecting that it would be something with the node version. I just couldn't detect what it was, it was late and I went to sleep. Thank you. I will check the changes and test with the mentioned node version. Anything else to recommend? Remember that the translations as already mentioned need to be synchronized. Need some more testing? |
Tests look good to me 👍 . Especially since they are actually failing with too optimistic implementation. |
Is this error related to code? |
@jaironalves If you want to gain some attribution on your GitHub profile for the commits, you might want to configure the emails of your account. Once correctly configured, we will see your avatar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side, great work!
Oops. I did not notice that it was not configured correctly on the computer. Apparently I believe I need to set the email in the repository. Do I need to rewrite commits once configured? |
@jaironalves You need the email used for the commit "jairon.lima@linx.com.br" to be verified on your GitHub account. I believe it's updated ingeniously once done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Especially considering the tests was a good call!
Close #20829
Implements the proposal mentioned in the issue #20829. In the case of .md files that have a greater number of links than the english version (
they are not synchronized
), use the translated link.