Add babel-plugin-dev expression #2107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently babel config is defined inline and in several places. This commit moves all the babel config to .babelrc
This plugin allows us to write shorter expressions to check if we are in a dev environment and to ouput warnings.
|
Haha, I have started doing it at #2105. |
|
@thomasguillory We merged the other PR. Thanks anyway for this one 👍. |
oliviertassinari
added
PR: needs revision
|
@thomasguillory Feel free to submit a new one if you think we can improve the way it's done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin allows us to write shorter expressions to check if we are in a dev environment and to ouput warnings.
This has been proposed here: #2039 (comment)
Note: the karma config file adds a sourceMap option to babel. I'm not sure how to test that these source maps are still generated with the new config. Can someone check that ?