Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional Label to the toggle component. #214

Merged
merged 4 commits into from
Jan 13, 2015
Merged

Conversation

mwq27
Copy link
Contributor

@mwq27 mwq27 commented Jan 8, 2015

Closes #213

@tschaub
Copy link
Contributor

tschaub commented Jan 9, 2015

What do you think about making label click/tap toggle the toggle state? This would make it act more like a native <label> for <input type="radio">.

@mwq27
Copy link
Contributor Author

mwq27 commented Jan 9, 2015

@tschaub Interesting, I could see some value in that. I'll make the update.

Thanks

hai-cea added a commit that referenced this pull request Jan 13, 2015
Adding optional Label to the toggle component.
@hai-cea hai-cea merged commit b4cdcad into mui:master Jan 13, 2015
@hai-cea
Copy link
Member

hai-cea commented Jan 13, 2015

Thanks @mwq27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: toggle button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Label to the Toggle component
4 participants