Bump eslint-plugin-jsx-a11y from 6.2.3 to 6.3.1 #21525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
github-actions
bot
added
the
PR: out-of-date
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) from 6.2.3 to 6.3.1. - [Release notes](https://github.com/evcohen/eslint-plugin-jsx-a11y/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/CHANGELOG.md) - [Commits](infofarmer/eslint-plugin-jsx-a11y@v6.2.3...v6.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview
bot
force-pushed
the
dependabot/npm_and_yarn/eslint-plugin-jsx-a11y-6.3.1
branch
from
453b49f to
4ea6af8
Compare
github-actions
bot
removed
the
PR: out-of-date
eps1lon
reviewed
Jun 23, 2020
| @@ -137,8 +137,8 @@ export default function ConfirmationDialog() { | |||
|
|
|||
| return ( | |||
| <div className={classes.root}> | |||
| <List component="div" role="list"> | |||
| <ListItem button divider disabled role="listitem"> | |||
| <List component="div" role="group"> | |||
There was a problem hiding this comment.
Makes more sense to group them with the current implementation of List (related to #13597 (comment)). I'd question the demo as a whole but this requires more context. It's using List for styles and has to go the extra mile to remove the implied semantics.
Let's leave it as is to get the build green and revisit this when working on #13597
oliviertassinari
approved these changes
Jun 23, 2020
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/eslint-plugin-jsx-a11y-6.3.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps eslint-plugin-jsx-a11y from 6.2.3 to 6.3.1.
Changelog
Sourced from eslint-plugin-jsx-a11y's changelog.
Commits
1614b85CHANGELOG v6.3.1b82b1bdMerge pull request #705 from jsx-eslint/fix-heading-error765da0fUpdate to aria-query 4.2.2d528e8cFix aria-level allowed on elements wit role heading (#704)3ac1738Merge pull request #674 from jsx-eslint/greenkeeper/estraverse-5.0.0bbfcb5aMerge branch 'master' into greenkeeper/estraverse-5.0.029c6859[meta] remove yarn registry from npmrc, so publishing works7b5d228Update CHANGELOG for v6.3.0e215b87Merge pull request #696 from jsx-eslint/fix-aria-1-2-test-failurescce838aUpdate aria-query to 4.2.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: