Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextareaAutosize] Rename rowsMax->maxRows & rowsMin->minRows #21873

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

mhayk
Copy link
Contributor

@mhayk mhayk commented Jul 21, 2020

Breaking changes

TextField

  • Rename rowsMax prop with maxRows for consistency with HTML attributes.

    -<TextField rowsMax={6}>
    +<TextField maxRows={6}>

TextareaAutosize

  • Rename rowsMax prop with maxRows for consistency with HTML attributes.

    -<TextareAutosize rowsMax={6}>
    +<TextareAutosize maxRows={6}>
  • Rename rowsMin prop with minRows for consistency with HTML attributes.

    -<TextareAutosize rowsMin={1}>
    +<TextareAutosize minRows={1}>

Part of #20012

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 21, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 322ff33

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting working on it, we would also need to handle rowsMin -> minRows

@mhayk mhayk changed the title [TextareaAutosize] Rename rowsMax -> maxRows for consistency [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows for consistency Jul 21, 2020
@mhayk
Copy link
Contributor Author

mhayk commented Jul 21, 2020

@oliviertassinari done! 👊

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 22, 2020

@dmtrKovalenko Any idea on the fail with the DatePicker? https://app.circleci.com/pipelines/github/mui-org/material-ui/15930/workflows/3b1b360c-2f3b-4482-b5f0-afed19f04433/jobs/165238

What about we hold this pull request, and we upgrade the dependency on the pickers from v3 to the last alpha release? At the minimum, it will move us in the right direction.

Capture d’écran 2020-07-22 à 12 49 13

@dmtrKovalenko
Copy link
Member

It is a typescript error caused by conflict in typings.

Yes upgrading pickers will solve the issue

@oliviertassinari
Copy link
Member

Alright, let's try the upgrade in another pull request and keep this one on hold :).
@dmtrKovalenko do you want to take care of it?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2020
Signed-off-by: Mhayk Whandson <hi@mhayk.com>
@oliviertassinari oliviertassinari changed the title [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows for consistency [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows Aug 2, 2020
@oliviertassinari oliviertassinari changed the title [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows [TextareaAutosize] Rename rowsMax->maxRows & rowsMin->minRows Aug 2, 2020
@oliviertassinari
Copy link
Member

@mhayk Thanks!

kodai3 pushed a commit to kodai3/material-ui that referenced this pull request Aug 3, 2020
@eps1lon eps1lon added this to the v5 milestone Aug 4, 2020
@eps1lon eps1lon mentioned this pull request Aug 5, 2020
42 tasks
@mbrookes
Copy link
Member

@mhayk Thanks for working on this. Would you be happy to work on adding a deprecation warning on the master branch?

@mhayk
Copy link
Contributor Author

mhayk commented Oct 15, 2020

Hey @mbrookes! Of course! I am going to do that .. thank you to invite me!

@mbrookes
Copy link
Member

@mhayk That's great, thanks! If you need any pointers, you can check other examples that have already been completed: #20012

@mbrookes
Copy link
Member

Hey @mhayk! 👋 Just checking if you still plan to work on adding a deprecation warning for v4? Thanks!

@mhayk
Copy link
Contributor Author

mhayk commented Nov 15, 2020

Hi @mbrookes .. sorry for the delay .. #23530. Could you review please ?

@mbrookes
Copy link
Member

@mhayk No need to apologize - thanks for working on it! It looks like there might be a couple of CI issues to fix. If the errors don't make sense, feel free to ping me on the PR, and I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants