-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextareaAutosize] Rename rowsMax->maxRows & rowsMin->minRows #21873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting working on it, we would also need to handle rowsMin
-> minRows
@oliviertassinari done! 👊 |
@dmtrKovalenko Any idea on the fail with the DatePicker? https://app.circleci.com/pipelines/github/mui-org/material-ui/15930/workflows/3b1b360c-2f3b-4482-b5f0-afed19f04433/jobs/165238 What about we hold this pull request, and we upgrade the dependency on the pickers from v3 to the last alpha release? At the minimum, it will move us in the right direction. |
It is a typescript error caused by conflict in typings. Yes upgrading pickers will solve the issue |
Alright, let's try the upgrade in another pull request and keep this one on hold :). |
Signed-off-by: Mhayk Whandson <hi@mhayk.com>
@mhayk Thanks! |
@mhayk Thanks for working on this. Would you be happy to work on adding a deprecation warning on the |
Hey @mbrookes! Of course! I am going to do that .. thank you to invite me! |
Hey @mhayk! 👋 Just checking if you still plan to work on adding a deprecation warning for v4? Thanks! |
@mhayk No need to apologize - thanks for working on it! It looks like there might be a couple of CI issues to fix. If the errors don't make sense, feel free to ping me on the PR, and I'll take a look. |
Breaking changes
TextField
Rename
rowsMax
prop withmaxRows
for consistency with HTML attributes.TextareaAutosize
Rename
rowsMax
prop withmaxRows
for consistency with HTML attributes.Rename
rowsMin
prop withminRows
for consistency with HTML attributes.Part of #20012