Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add useRadioGroup section #21910

Merged
merged 5 commits into from
Jul 27, 2020
Merged

[docs] Add useRadioGroup section #21910

merged 5 commits into from
Jul 27, 2020

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Jul 24, 2020

Fixes #18918

(I'm native Japanese speaker, so translated just ja.md)

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 24, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 938e0b7

@github-actions github-actions bot mentioned this pull request Jul 24, 2020
Closed
eps1lon
eps1lon previously requested changes Jul 24, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should include the returned interface. Do you have an existing use case that uses this feature. Including an example would help a lot.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 24, 2020
@oliviertassinari oliviertassinari changed the title [doc]add useRadioGroupContext section [docs] Add useRadioGroupContext section Jul 24, 2020
@oliviertassinari oliviertassinari changed the title [docs] Add useRadioGroupContext section [docs] Add useRadioGroup section Jul 24, 2020
@kodai3
Copy link
Contributor Author

kodai3 commented Jul 24, 2020

Thanks! We should include the returned interface. Do you have an existing use case that uses this feature. Including an example would help a lot.

added demo and return section like gif below
4ae55d8

https://gyazo.com/70d99b6a79d32a8d5b7878d62c870965

@eps1lon eps1lon merged commit 88fa20f into mui:next Jul 27, 2020
@eps1lon
Copy link
Member

eps1lon commented Jul 27, 2020

@kodai3 Much appreciated, thanks!

@kodai3
Copy link
Contributor Author

kodai3 commented Jul 27, 2020

@eps1lon @oliviertassinari Thanks for guide me through my first PR to be merged🎉

@hzhz hzhz mentioned this pull request Feb 16, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 13, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Open
@hzhz hzhz mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose RadioGroupContext via useRadioGroup Hook
5 participants
@kodai3 @mui-pr-bot @eps1lon @oliviertassinari @joshwooding