[RootRef] Remove component #21974
Merged
[RootRef] Remove component #21974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: -0.47% 😍, gzip: -0.60% 😍 |
joshwooding
reviewed
Jul 28, 2020
| ### RootRef | ||
|
|
||
| - This component was removed. | ||
| You can get a reference to the underlying DOM node of our components via `ref` prop. |
There was a problem hiding this comment.
You mean
Suggested change
| You can get a reference to the underlying DOM node of our components via `ref` prop. | |
| You can get a reference to the underlying DOM node of our components via the `ref` prop. |
?
github-actions
bot
added
the
PR: out-of-date
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
eps1lon
removed
the
PR: out-of-date
oliviertassinari
approved these changes
Jul 29, 2020
| @@ -102,8 +102,6 @@ module.exports = { | |||
| 'react/no-array-index-key': 'off', | |||
| 'react/no-danger': 'error', | |||
| 'react/no-direct-mutation-state': 'error', | |||
| // Required for backward compatibility. TODO v5, drop | |||
| 'react/no-find-dom-node': 'off', | |||
There was a problem hiding this comment.
Cool, I have created a note to remove that rule from the material-ui-x repository.
oliviertassinari
added a commit
to oliviertassinari/mui-x
that referenced
this pull request
Aug 1, 2020
oliviertassinari
added a commit
to oliviertassinari/mui-x
that referenced
this pull request
Aug 1, 2020
oliviertassinari
added a commit
to oliviertassinari/mui-x
that referenced
this pull request
Aug 2, 2020
oliviertassinari
added a commit
to oliviertassinari/mui-x
that referenced
this pull request
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
This component was removed. You can get a reference to the underlying DOM node of our components via
refprop.The component relied on
ReactDOM.findDOMNodewhich is deprecated inReact.StrictMode.RootRefis no longer needed for our components nor used internally. If people still need this component they can copy the old source.Follow-up: