Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Remove theme.mixins.gutters #22109

Merged
merged 1 commit into from
Aug 10, 2020
Merged

[theme] Remove theme.mixins.gutters #22109

merged 1 commit into from
Aug 10, 2020

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Aug 8, 2020 •
edited by oliviertassinari
Loading

Breaking change

The abstraction hasn't proven to be used frequently enough to be valuable.

-theme.mixins.gutters(),
+paddingLeft: theme.spacing(2),
+paddingRight: theme.spacing(2),
+[theme.breakpoints.up('sm')]: {
+  paddingLeft: theme.spacing(3),
+  paddingRight: theme.spacing(3),
+},

An easy one to cross off.

Part of #20012

@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against d5e3c71

@github-actions github-actions bot mentioned this pull request Aug 8, 2020
Closed
@joshwooding joshwooding merged commit 3b8f9b0 into mui:next Aug 10, 2020
@joshwooding joshwooding deleted the remove-theme-mixins-gutters branch August 10, 2020 18:20
@oliviertassinari oliviertassinari mentioned this pull request Aug 11, 2020
Closed
@oliviertassinari
Copy link
Member

@joshwooding Don't forget about the deprecation on v4 :)

@joshwooding joshwooding mentioned this pull request Aug 17, 2020
Merged
1 task
@mnajdova mnajdova mentioned this pull request Aug 29, 2020
Merged
@eps1lon eps1lon added this to the v5 milestone Sep 15, 2020
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@feedmypixel feedmypixel mentioned this pull request Jul 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change package: material-ui Specific to @mui/material
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@joshwooding @mui-pr-bot @oliviertassinari @eps1lon