Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Remove transition onX props #22113

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 8, 2020

Breaking change

  • The onE* transition props were removed. Use TransitionProps instead.

    <Dialog
    -  onEnter={onEnter}
    -  onEntered={onEntered},
    -  onEntering={onEntered},
    -  onExit={onEntered},
    -  onExited={onEntered},
    -  onExiting={onEntered}
    +  TransitionProps={{
    +    onEnter,
    +    onEntered,
    +    onEntering,
    +    onExit,
    +    onExited,
    +    onExiting,
    +  }}
    />

#17047 (comment)

@mbrookes mbrookes added breaking change component: dialog This is the name of the generic UI component, not the React module! labels Aug 8, 2020
@mbrookes mbrookes added this to the v5 milestone Aug 8, 2020
@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 128797b

@mbrookes mbrookes merged commit c6aa772 into mui:next Aug 10, 2020
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
42 tasks
@mbrookes mbrookes deleted the dialog-remove-onX-props branch November 3, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants