Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridList] Rename to ImageList #22311

Merged
merged 5 commits into from
Aug 26, 2020
Merged

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 22, 2020

Part of #20012

GridList

Rename the GridList components to ImageList to align with the current Material Design naming.

-import GridList from '@material-ui/core/GridList';
-import GridListTile from '@material-ui/core/GridListTile';
-import GridListTileBar from '@material-ui/core/GridListTileBar';
+import ImageList from '@material-ui/core/ImageList';
+import ImageListTile from '@material-ui/core/ImageListTile';
+import ImageListTileBar from '@material-ui/core/ImageListTileBar';
 
-<GridList>
-  <GridListTile>
+<ImageList>
+  <ImageListTile>
     <img src="file.jpg" alt="Image title" />
-    <GridListTileBar
+    <ImageListTileBar
       title="Title"
       subtitle="Subtitle"
     />
-  </GridListTile>
-</GridList>
+  </ImageListTile>
+</ImageList>

@mbrookes mbrookes added breaking change component: image list This is the name of the generic UI component, not the React module! component: ImageList labels Aug 22, 2020
@mbrookes mbrookes added this to the v5 milestone Aug 22, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 22, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 78a8835

@mbrookes
Copy link
Member Author

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 22, 2020

What should we do with the legacy codemod?

Maybe removing the component from the test to avoid confusion? Later, we could inline the index.js we had during v4 for the tests.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 24, 2020
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 25, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 25, 2020
@mbrookes mbrookes merged commit 3da0347 into mui:next Aug 26, 2020
@mbrookes mbrookes deleted the gridlist-rename-imagelist branch August 26, 2020 00:21
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: image list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants