Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Move utils package to TypeScript #22367

Merged
merged 12 commits into from
Aug 31, 2020
Merged

[core] Move utils package to TypeScript #22367

merged 12 commits into from
Aug 31, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 26, 2020 •
edited
Loading

Migrate @material-ui/utils to TypeScript to unlock #22346.

@oliviertassinari oliviertassinari added typescript core Infrastructure work going on behind the scenes labels Aug 26, 2020
@oliviertassinari oliviertassinari force-pushed the add-typescript-utils-coverage branch 6 times, most recently from fcf584f to 308ed05 Compare August 26, 2020 13:59
@oliviertassinari oliviertassinari marked this pull request as ready for review August 26, 2020 13:59
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 26, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against ddb8950

eps1lon
eps1lon previously requested changes Aug 28, 2020
View reviewed changes
packages/material-ui-utils/package.json Show resolved Hide resolved
packages/material-ui-utils/package.json Outdated Show resolved Hide resolved
packages/material-ui-utils/src/HTMLElementType.ts Outdated Show resolved Hide resolved
packages/material-ui-utils/src/chainPropTypes.ts Outdated Show resolved Hide resolved
packages/material-ui-utils/src/chainPropTypes.ts Outdated Show resolved Hide resolved
packages/material-ui-utils/src/deepmerge.ts Outdated Show resolved Hide resolved
packages/material-ui-utils/src/elementAcceptingRef.ts Outdated Show resolved Hide resolved
packages/material-ui-utils/src/elementTypeAcceptingRef.test.tsx Outdated Show resolved Hide resolved
packages/material-ui-utils/src/elementTypeAcceptingRef.test.tsx Outdated Show resolved Hide resolved
packages/material-ui-utils/src/elementTypeAcceptingRef.ts Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari force-pushed the add-typescript-utils-coverage branch 3 times, most recently from bb3c272 to 1bfb03c Compare August 28, 2020 10:31
@oliviertassinari oliviertassinari dismissed eps1lon’s stale review August 28, 2020 11:41

I have fixed what I could

@eps1lon eps1lon self-assigned this Aug 30, 2020
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 31, 2020
@oliviertassinari oliviertassinari force-pushed the add-typescript-utils-coverage branch from 4a699c0 to ddb8950 Compare August 31, 2020 13:04
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 31, 2020
eps1lon
eps1lon approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@oliviertassinari oliviertassinari force-pushed the add-typescript-utils-coverage branch from 616e65f to ddb8950 Compare August 31, 2020 13:46
@oliviertassinari oliviertassinari merged commit 6445fb2 into mui:next Aug 31, 2020
@oliviertassinari oliviertassinari deleted the add-typescript-utils-coverage branch August 31, 2020 13:46
@oliviertassinari oliviertassinari mentioned this pull request Dec 7, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

@eps1lon eps1lon

Labels
core Infrastructure work going on behind the scenes typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-pr-bot @eps1lon