Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vendor prefix needed for Safari 8 #2248

Closed
wants to merge 1 commit into from

Conversation

wardy
Copy link

@wardy wardy commented Nov 23, 2015

Added vendor prefix needed for Safari 8 http://caniuse.com/#feat=flexbox @AHBSky

@wardy
Copy link
Author

wardy commented Nov 23, 2015

#2145

@oliviertassinari
Copy link
Member

@wardywork Could you update the PR with the source and not the genereared code by babel?

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Nov 23, 2015
@@ -56,6 +56,7 @@ const GridList = React.createClass({
root: {
display: '-webkit-box; display: -moz-box; display: -ms-flexbox; display: -webkit-flex; display: flex',
flexWrap: 'wrap',
WebkitFlexWrap: 'wrap',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using https://github.com/rofrischmann/inline-style-prefixer so we shouldn't need it.
I think that we should remove the prefixes from the above display property

@wardy
Copy link
Author

wardy commented Nov 24, 2015

Hey I just checked their docs and I can't see that they actually support flex-wrap it's not in their supported properties. You raise a good point about the display styles however.

@oliviertassinari
Copy link
Member

Interesting, I have opened an issue. Could you update the display property? I will merge then.
We should remove the property once https://github.com/rofrischmann/inline-style-prefixer support it (could you add a comment on the line so that we don't forgot ?)

@oliviertassinari
Copy link
Member

Edit, the property was added by robinweser/inline-style-prefixer@658a165. So I think that we can stick to only updating the display property.

@oliviertassinari
Copy link
Member

@wardywork With #2313, it should be all good now.
Feel free to open an issue, if it's still not fixed. Thanks.

@wardy
Copy link
Author

wardy commented Dec 1, 2015

Appears to be working great now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants