-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added vendor prefix needed for Safari 8 #2248
Conversation
@wardywork Could you update the PR with the source and not the genereared code by babel? |
e865f93
to
448d813
Compare
@@ -56,6 +56,7 @@ const GridList = React.createClass({ | |||
root: { | |||
display: '-webkit-box; display: -moz-box; display: -ms-flexbox; display: -webkit-flex; display: flex', | |||
flexWrap: 'wrap', | |||
WebkitFlexWrap: 'wrap', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using https://github.com/rofrischmann/inline-style-prefixer so we shouldn't need it.
I think that we should remove the prefixes from the above display
property
Hey I just checked their docs and I can't see that they actually support flex-wrap it's not in their supported properties. You raise a good point about the display styles however. |
Interesting, I have opened an issue. Could you update the display property? I will merge then. |
Edit, the property was added by robinweser/inline-style-prefixer@658a165. So I think that we can stick to only updating the display property. |
@wardywork With #2313, it should be all good now. |
Appears to be working great now 👍 |
Added vendor prefix needed for Safari 8 http://caniuse.com/#feat=flexbox @AHBSky