Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpeedDial] Move from lab to core #22743

Merged
merged 6 commits into from
Sep 28, 2020
Merged

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Sep 26, 2020

Breaking changes

  • [SpeedDial] Move the component from the lab to the core. The component will become stable.

    -import SpeedDial from '@material-ui/lab/SpeedDial';
    -import SpeedDialAction from '@material-ui/lab/SpeedDialAction';
    -import SpeedDialIcon from '@material-ui/lab/SpeedDialIcon';
    +import SpeedDial from '@material-ui/core/SpeedDial';
    +import SpeedDialAction from '@material-ui/core/SpeedDialAction';
    +import SpeedDialIcon from '@material-ui/core/SpeedDialIcon';

@mbrookes mbrookes added breaking change component: speed dial This is the name of the generic UI component, not the React module! labels Sep 26, 2020
@mbrookes mbrookes added this to the v5 milestone Sep 26, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 26, 2020

@material-ui/core: parsed: 0.00% 😍, gzip: -0.14% 😍
@material-ui/lab: parsed: +0.38% , gzip: +0.50%

Details of bundle changes

Generated by 🚫 dangerJS against d9b1df3

@mbrookes mbrookes marked this pull request as ready for review September 26, 2020 19:22
@mbrookes mbrookes merged commit 814fb60 into mui:next Sep 28, 2020
@mbrookes mbrookes deleted the speeddial-move-to-core branch September 28, 2020 20:26
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 29, 2020

The change seems to break the CI on the next branch. I haven't looked closer. I have rerun the CI for 8ea6bbf (before #22743) and 814fb60 (#22743). The first one passes, while the second fails.
It's to be noted that we don't run code coverage on the tests that are in the lab.

@oliviertassinari oliviertassinari mentioned this pull request Oct 22, 2020
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants