Skip to content

[Popper] Use placement viewport instead of window #22748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2020
Merged

[Popper] Use placement viewport instead of window #22748

merged 2 commits into from
Sep 28, 2020

Conversation

@maksimgm
Copy link
Contributor

@maksimgm maksimgm commented Sep 26, 2020 •
edited by oliviertassinari
Loading

Closes #22708

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 26, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 22a193c

@github-actions github-actions bot mentioned this pull request Sep 26, 2020
Closed
@oliviertassinari oliviertassinari changed the title [popper] When placement is set to "right" or "left", placement doesn't update based on viewport position [Popper] Use placement viewport instead of window Sep 27, 2020
@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. component: Popper The React component. See <Popup> for the latest version. labels Sep 27, 2020
@oliviertassinari oliviertassinari merged commit 8ea6bbf into mui:next Sep 28, 2020
@oliviertassinari
Copy link
Member

@maksimgm thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

component: Popper The React component. See <Popup> for the latest version. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Popper] When placement is set to "right" or "left", placement doesn't update based on viewport position

3 participants

@maksimgm @mui-pr-bot @oliviertassinari