[docs] Add page feedback #22885
Merged
[docs] Add page feedback #22885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
eps1lon
reviewed
Oct 5, 2020
There was a problem hiding this comment.
This is great. Really looking forward to the feedback.
About the infra: Why is docs/rating not included in the workspaces? By including it we wouldn't need the extra install command.
About the actual UI: Since this includes quite some code, needs interactivity we and is located at the bottom we probably want to lazy load it. That way we can have a dedicated component (MarkDownDocs is quite big) and don't add that much to the initial bundle size.
eps1lon
previously requested changes
Oct 5, 2020
eps1lon
reviewed
Oct 5, 2020
eps1lon
reviewed
Oct 5, 2020
This comment has been minimized.
This comment has been minimized.
oliviertassinari
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
A couple of thoughts:
- If we include the version, we could also include the language too in the feedback record.
- I have a few doubts about DynamoDB as the best database for our problem. DynamoDB does not provide aggregation functions. So if we want to compute the global mean for all the pages, compare the rating for each version, for each language, for different quarters, etc. We won't be able to do it easily. It seems that we would need to go into the ETL land, load the data in a Redshift, or in Athena, etc. Not as simple as running a SQL AVG() aggregation function.
- I wonder about the precision of:
rating = (average * count + request.body.rating) / (count + 1);once you get >1,000 feedback.
oliviertassinari
approved these changes
Oct 16, 2020
mbrookes
commented
Oct 17, 2020
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
mbrookes
force-pushed
the
docs-ratings
branch
3 times, most recently
from
2ec33b4 to
1df3b19
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page feedback
Preview
UI
Feedback
Submit notification