[docs] Interoperability guide updates #23030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mnajdova
commented
Oct 13, 2020
•
mnajdova
commented
- I have followed (at least) the PR section of the contributing guide.
mbrookes
reviewed
Oct 13, 2020
oliviertassinari
requested changes
Oct 13, 2020
There was a problem hiding this comment.
A first iteration on the review, the same feedback can often be applied at different places in the documentation.
- Seeing the implications of moving the specificity from 1 to 2 makes me think that a -20% performance degradation could be fine compared to the customization questions we will get about what's CSS specificity? Is it when we inverse the order of the class names on the attribute? Nop
- In the codesandbox, I would recommend using npm tags (instead of a specific version), this helps ensures we get feedback if something break, it also removes the need to update the version.
mbrookes
requested changes
Oct 13, 2020
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
force-pushed
the
docs/interoperability-cleanup
branch
from
1c0ca57 to
7c6a6f0
Compare
github-actions
bot
removed
the
PR: out-of-date
…ajdova/material-ui into docs/interoperability-cleanup
oliviertassinari
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
@mnajdova I have pushed a commit to catch inconsistencies and act on the improvement opportunities I could spot (faster than leaving a comment). Happy to discuss any of my changes.
|
One thing that would be great, long term, is to move the codesandboxes to our "Team" so everybody can improve them. |
mbrookes
previously requested changes
Oct 15, 2020
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.