Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typedefs to use boolean instead of true/false #23038

Closed
wants to merge 1 commit into from
Closed

Update typedefs to use boolean instead of true/false #23038

wants to merge 1 commit into from

Conversation

josh-degraw
Copy link

Some type definitions were using true or false literals when it seems boolean was intended. This PR attempts to fix that.

@mui-pr-bot
Copy link

No bundle size changes comparing a6b330c...c54b05d

Generated by 🚫 dangerJS against c54b05d

@eps1lon
Copy link
Member

eps1lon commented Oct 13, 2020

Please check out #14971 and #16245 for prior reports. For an in-depth explainer why these are literals instead of boolean see #15049 (which includes requirements for when we would accept a fix).

@eps1lon eps1lon added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI typescript labels Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh-degraw @mui-pr-bot @eps1lon