Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add support for iOS Safari 12 #23068

Merged
merged 3 commits into from
Oct 16, 2020
Merged

[core] Add support for iOS Safari 12 #23068

merged 3 commits into from
Oct 16, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 15, 2020

Seems like I forgot ios_safari 12.2 in #22814. The other changes are due to new version releases (mainly Firefox ESR moving to 78).

Safari 12 sits at 2% global usage. But other than IE 11 where we argue that this browser is mostly used in corporate enviornments (with an LTS license) iOS Safari 12 is used by actual people that would need to buy a new phone in order to upgrade to Safari 13. So I don't think the usage stats can solely be used as justification to drop it.

The unfortunate part is that this won't allow an all-in usage of PointerEvent. But we'll get there eventually.

The good part is that ImageList should function perfectly well in iOS Safari 12 looking at gap and column-gap support

@eps1lon eps1lon added the core Infrastructure work going on behind the scenes label Oct 15, 2020
@eps1lon eps1lon changed the title [core] Update browserslist stable snapshot [core] Add support for iOS Safari 12 Oct 15, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 15, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 12c96cf

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, iOS 12 isn't going away as easily as the previous versions: https://gs.statcounter.com/ios-version-market-share/mobile/worldwide/#monthly-201804-202009.

Shouldn't we update https://next--material-ui.netlify.app/getting-started/supported-platforms/#browser in this case?
What's the difference between Safari on iOS and macOS? I thought they were using the same engine.

@eps1lon
Copy link
Member Author

eps1lon commented Oct 15, 2020

Shouldn't we update next--material-ui.netlify.app/getting-started/supported-platforms/#browser in this case?

Yes, I forgot 👍

What's the difference between Safari on iOS and macOS? I thought they were using the same engine.

Kind of depends what you mean by "engine". I just treat them as different browsers because they are. How similar they are under the hood is not really a concern for me. Why are you asking?

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 15, 2020

Why are you asking?

I'm asking regarding what we should document and how.

@eps1lon
Copy link
Member Author

eps1lon commented Oct 15, 2020

Seems like they are in fact different: https://stackoverflow.com/questions/3006647/list-of-known-safari-on-ipad-differences-over-desktop-safari

Maybe that's just historical but I'd treat them differently.

@oliviertassinari
Copy link
Member

Maybe that's just historical but I'd treat them differently.

Same for Chrome?

@eps1lon
Copy link
Member Author

eps1lon commented Oct 15, 2020

If it has a different name it's a different browser in my book. Not sure what we are discussing here?

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 15, 2020

My point is that if we are handling Safari differently based on mobile vs desktop, shouldn't we do the same for chrome?

https://caniuse.com/?search=pointer
Capture d’écran 2020-10-15 à 16 11 01
Capture d’écran 2020-10-15 à 16 08 53
Capture d’écran 2020-10-15 à 16 08 45
Capture d’écran 2020-10-15 à 16 08 42

@eps1lon
Copy link
Member Author

eps1lon commented Oct 15, 2020

My point is that if we are handling Safari differently based on mobile vs desktop, shouldn't we do the same for chrome?

Haven't thought about it. If you're aware of inconsistencies then we should probably include it. Though it might be ok to ignore 1 version differences for evergreen browsers.

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon merged commit 0958fd4 into mui:next Oct 16, 2020
@eps1lon eps1lon deleted the feat/safari-12 branch October 16, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants