Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix bundles for packages without subpackages #23157

Merged
merged 4 commits into from
Oct 20, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 19, 2020

Affected packages:

  • @material-ui/icons
  • @material-ui/system
  • @material-ui/utils

I had some assumptions about our packages that don't hold for all @material-ui/* packages. In a perfect world these would hold since it makes easier to work with them (as maintainer and, more importantly, app dev) but we have adjust for the way people consume Material-UI today.

This is not the ideal fix for #23120 but I'd rather get a working™ fix out soon as possible so that we can cut a release.

  1. Get deploy of new bundles
  2. Create test fixture covering (tracked in [test] Add bundle fixtures #23166)

Closes #23120

@eps1lon eps1lon added the core Infrastructure work going on behind the scenes label Oct 19, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 19, 2020

No bundle size changes comparing 13f3e9d...7839b1e

Generated by 🚫 dangerJS against 7839b1e

@eps1lon eps1lon marked this pull request as ready for review October 19, 2020 16:13
@eps1lon eps1lon mentioned this pull request Oct 19, 2020
8 tasks
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great

@eps1lon eps1lon merged commit 8023b1c into mui:next Oct 20, 2020
@eps1lon eps1lon deleted the fix/bundle-assumptions branch October 20, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icons-v5] Cannot use import statement outside a module
3 participants