-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Add sx prop in SliderStyled #23205
Conversation
…into feat/box-sx-prop
I'm not really following how this prop is useful for complex components. Could you share a real-world use case? |
@eps1lon In https://next.material-ui.com/system/basics/#real-world-use-case, it allows removing the I have added the issue we aim to close in the PR's description: #15561. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
packages/material-ui-lab/src/SliderUnstyled/SliderUnstyled.d.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
I wouldn't recommend adding examples for this per component. Next step will be to introduce a documentation for the |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Could somebody summarize for me what the real-world use case is now? The PR body still has the styling that I wouldn't expect to find anywhere. |
I wonder, did we drop the diff --git a/packages/material-ui-lab/src/SliderStyled/SliderStyled.d.ts b/packages/material-ui-lab/src/SliderStyled/SliderStyled.d.ts
index 3b80b4c843..3cc143142c 100644
--- a/packages/material-ui-lab/src/SliderStyled/SliderStyled.d.ts
+++ b/packages/material-ui-lab/src/SliderStyled/SliderStyled.d.ts
@@ -36,6 +36,8 @@ export const SliderTrack: React.FC<SliderTrackProps>;
export const SliderThumb: React.FC<SliderThumbProps>;
export const SliderValueLabel: React.FC<SliderValueLabel>;
+export type SliderProps = SliderStyledTypeMap['props'];
+
/**
*
* Demos: |
This PR adds the
sx
prop on theSliderStyled
component.Example usage:
Related to #15561