[Modal] Add support for onKeyDown and remove onEscapeKeyDown

[eps1lon]

Breaking changes

• [Modal] Remove the onEscapeKeyDown prop. It's redundant with the reason argument.

 <Modal
-  onEscapeKeyDown={handleEscapeKeyDown}
+  onClose={(event, reason) => {
+    if (reason === "escapeKeyDown") {
+      handleEscapeKeyDown(event);
+    }
+  }}
 />;

---

As far as I can tell it can be implemented in userland with onKeyDown or onClose (+ reason).

It was first introduced as onEscapeKeyUp in c644597

[mui-pr-bot]

Details of bundle changes

Generated by 🚫 dangerJS against f372c84

[oliviertassinari]

I wouldn't stop here 😆 https://trello.com/c/YOOkA2US/2556-modal-remove-drop-disablebackdropclick-onbackdropclick-onescapekeydown-disableescapekeydown

[eps1lon]

There's definitely more opportunity. Some of them have equivalent behavior that we haven't settled on (e.g. preventDefault).

For reviewability and changelog reasons I would work on them separately.

[eps1lon]

It's not pretty since this function has the same issue as most of the code inlined from ttp: Overloading functions to increase re-usability instead of splitting them for individual use cases.

I expect that this kind of props tracking through throughout the component might increase with the removal of withStyles at which point we can refactor this code.

[oliviertassinari]

Do we miss a description of the breaking change in the migration guide and in the PR's description (I use that to generate the changelog)?