[styles] Add support for TypeScript 4.1 #23633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
test
typescript
package: styles
This reverts commit df2a300.
eps1lon
commented
Nov 20, 2020
| export default function makeStyles< | ||
| Theme = DefaultTheme, | ||
| Props extends {} = {}, | ||
| Props extends object = {}, |
There was a problem hiding this comment.
Little correction while we're at it. The types we pass this to expect object as well.
eps1lon
commented
Nov 20, 2020
Comment on lines
-84
to
85
| // would be nice to have at least a compile time error because we forgot the argument | ||
| // @ts-expect-error | ||
| const classes = useUnsafeProps(); // runtime: Can't read property color of undefined |
There was a problem hiding this comment.
Actually improved the types.
oliviertassinari
approved these changes
Nov 21, 2020
oliviertassinari
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] Don't bail on monorepo typescript task
Right now we're exiting on the very first error.
This is not in line with other test-like tasks we have (e.g.
yarn lintoryarn test:unit).It also hid a more severe issue makeStyles overload breakage with TypeScript 4.1 #23627.
[styles] Fix useStyles requiring props in TS 4.1
-- https://app.circleci.com/pipelines/github/mui-org/material-ui/27542/workflows/e3a4c4a4-19dc-4c38-84d9-044fc34a6fd3/jobs/197844
[utils] Fix deepmerge return type for falsy inputs
-- https://app.circleci.com/pipelines/github/mui-org/material-ui/27542/workflows/e3a4c4a4-19dc-4c38-84d9-044fc34a6fd3/jobs/197844
Closes #23627