Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ButtonBase] Cancel ripple if touch was interrupted #23829

Closed
wants to merge 1 commit into from

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 3, 2020

Need deploy for experiment with #23808

Closes #23808

@eps1lon eps1lon added the component: ButtonBase The React component. label Dec 3, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 3, 2020

Details of bundle changes

Generated by 🚫 dangerJS against c145c59

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 7, 2020

@eps1lon Do you need to keep this pull request open? From what I understand, the logic removed is required to trigger the ripple when the touchstart -> touchend session span for less than 80ms.

@eps1lon
Copy link
Member Author

eps1lon commented Dec 7, 2020

From what I understand, the logic removed it required to trigger the ripple when the touchstart -> touchend session span for less than 80ms.

Yes, this is what the code is doing. We have #23808 for why it is doing this.

Do you need to keep this pull request open?

Yes, see #23808

@oliviertassinari
Copy link
Member

What's the next step?

@eps1lon
Copy link
Member Author

eps1lon commented Dec 7, 2020

What's the next step?

You haven't really addressed #23808 i.e. why do you think the current behavior is intended? Also waiting for a response to #23808 (comment) but that might be unlikely considerig you already closed the issue.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 7, 2020

why do you think the current behavior is intended?

From what I understand with "intended", you are asking if we were aware of this issue when we merged #3407? I believe we were, yes.

Also waiting for a response to #23808 (comment)

Ok, let's wait :). I have reported one important downside with the approach to the issue: #23808 (comment).

you already closed the issue

If there is an alternative tradeoff that has more potential, it would be interesting to reopen. If not, I think that we might as well ignore it, there are many other issues with high ROI we can work on :).

@eps1lon eps1lon deleted the fix/button/touch-ripple-cancel branch September 14, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ButtonBase The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TouchRipple] Do not trigger it when scrolling
3 participants