Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[envinfo] Ask for output from envinfo in issues #23881

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 7, 2020

Reduces work required when opening an issue and provides better environment information by leveraging envinfo:

(Currently only works if you've checked out this branch and ran yarn. Once this is merged and published it works as advertised.)

$ npx @material-ui/envinfo

  System:
    OS: Linux 5.4 Ubuntu 20.04.1 LTS (Focal Fossa)
  Binaries:
    Node: 12.20.0 - ~/.nvm/versions/node/v12.20.0/bin/node
    Yarn: 1.22.4 - /usr/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.20.0/bin/npm
  Browsers:
    Chrome: 87.0.4280.66
    Firefox: 83.0
  npmPackages:
    @emotion/react: ^11.0.0 => 11.1.1
    @emotion/styled: ^11.0.0 => 11.0.0
    @material-ui/codemod:  5.0.0-alpha.17
    @material-ui/core:  5.0.0-alpha.18
    @material-ui/docs:  5.0.0-alpha.1
    @material-ui/envinfo:  1.0.0
    @material-ui/icons:  5.0.0-alpha.15
    @material-ui/lab:  5.0.0-alpha.18
    @material-ui/styled-engine:  5.0.0-alpha.18
    @material-ui/styled-engine-sc:  5.0.0-alpha.18
    @material-ui/styles:  5.0.0-alpha.18
    @material-ui/system:  5.0.0-alpha.18
    @material-ui/types:  5.1.0
    @material-ui/unstyled:  5.0.0-alpha.18
    @material-ui/utils:  5.0.0-alpha.18
    @types/react: ^17.0.0 => 17.0.0
    react: ^16.14.0 => 16.14.0
    react-dom: ^16.14.0 => 16.14.0
    styled-components:  5.2.1
    typescript: ^4.0.2 => 4.0.5

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 7, 2020

No bundle size changes

Generated by 🚫 dangerJS against d0ee86f

@eps1lon eps1lon marked this pull request as ready for review December 7, 2020 16:06
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Dec 7, 2020
@eps1lon eps1lon merged commit 194670d into mui:next Dec 7, 2020
@eps1lon eps1lon deleted the feat/envinfo branch December 7, 2020 20:10
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 7, 2020

Nice, even for us, when we spot a problem, it can make it easier to open a new issue :)

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 9, 2020

@eps1lon What do you think about disabling the output for browsers and asking developers to provide it?

I have seen two issues today with multiple browsers listed but no way to know which one to pay attention to.

@eps1lon
Copy link
Member Author

eps1lon commented Dec 9, 2020

I have seen two issues today with multiple browsers listed but no way to know which one to pay attention to.

So before you had no info, now you have all the info. How is it worse to know all opposed to nothing?

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 9, 2020

So before you had no info, now you have all the info. How is it worse to know all opposed to nothing?

I think that having the browser information is great, although browsers tend to be more and more evergreen. The problem is that we do no longer ask about the platform of end-users, If an issue happens on Safari iOS we need to know.

Now, we ask what the developers are using, only, which is one part. I fear that developers will assume it's enough and not bother providing more info. I think that two days of hindsight is too short to make any conclusion, we will likely learn more in the coming days.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 12, 2020

Once we have stabilized this new issue template (behave as expected with developers), we need to use it on https://github.com/mui-org/material-ui-x/blob/master/.github/ISSUE_TEMPLATE/1.bug.md too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants