Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListItem] Add option to Toggle Nested List Items on Primary Action #2390

Merged

Conversation

alitaheri
Copy link
Member

Continuation of #1648. Closes #1597.

Please review and merge @oliviertassinari.

@oliviertassinari
Copy link
Member

@subjectix That's a great idea to continue existing PR 👍.

@@ -46,6 +46,7 @@ const ListItem = React.createClass({
onTouchStart: React.PropTypes.func,
onTouchTap: React.PropTypes.func,
primaryText: React.PropTypes.node,
primaryTogglesNestedList: React.PropTypes.bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you set the false default value? (for the documentation-generator)

@alitaheri
Copy link
Member Author

done

Let me rebase.

@alitaheri alitaheri force-pushed the list-item-primary-toggles-nested-list-prop branch from fbe30fc to c60ec88 Compare December 6, 2015 21:36
alitaheri added a commit that referenced this pull request Dec 6, 2015
…ted-list-prop

[ListItem] Add option to Toggle Nested List Items on Primary Action
@alitaheri alitaheri merged commit 96ba689 into mui:master Dec 6, 2015
@alitaheri alitaheri deleted the list-item-primary-toggles-nested-list-prop branch December 6, 2015 21:39
@zannager zannager added the component: list This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle nested ListItems also when clicked (not just when tapped on the right icon toggle)
3 participants