[Icons] deprecate default value for fontSize in favor of medium
#23951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
added
component: Icon
Details of bundle changes.Comparing: b0e10a1...d813865 Details of page changes
|
mnajdova
reviewed
Dec 11, 2020
mnajdova
reviewed
Dec 11, 2020
mnajdova
reviewed
Dec 11, 2020
mnajdova
reviewed
Dec 11, 2020
mnajdova
reviewed
Dec 11, 2020
| @@ -15,7 +15,7 @@ export interface SvgIconTypeMap<P = {}, D extends React.ElementType = 'svg'> { | |||
| /** | |||
| * The fontSize applied to the icon. Defaults to 24px, but can be configure to inherit font size. | |||
| */ | |||
| fontSize?: 'inherit' | 'default' | 'small' | 'large'; | |||
| fontSize?: 'inherit' | 'large' | 'medium' | 'small'; | |||
There was a problem hiding this comment.
If this is a deprecation, shouldn't we have both default and medium to allow migration? Otherwise, we are breaking the build with this change.
|
Deprecations should be applied on the |
|
@mnajdova thanks. Where's the "quick, hide this PR so no-one notices the copy-pasta" button? |
|
@oliviertassinari "Deprecations should be applied on the v4-deprecations branch." I only have myself to blame for that. "It's simple" I said. 😆 |
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mui-org/material-ui/egqzfq3td |
|
Closing to change target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation for #23950