-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap #2403
Roadmap #2403
Conversation
Nice! I will let @shaurya947 merge if he is ok with it. |
I think that you could add another future :
|
@subjectix @oliviertassinari I commented on the gist and am generally ok with this. I'll have @hai-cea take a look before it is merged.. |
Good to see this. As mentioned elsewhere, I believe standardising the API should be a roadmap item, both in terms of gaps in available API calls (where relevant), and API naming inconsistencies. Perhaps when the autodocs are done you could generate a table of what api calls are available for what components? That would highlight where the gaps and inconsistencies are. |
@mbrookes Yeah we've had this issue in many places. I like your idea. I'm gonna update the roadmap. |
Thanks. Where possible it would also be good to standardise the callback parameter ordering for events etc. When developing formsy-material-ui I had to have different versions of effectively the same callback due to variations in the parameter order and response format between MUI form components. I know that will be harder than just renaming and aliasing deprecated function names, but worth it in the long run for reduced cognitive load and code simplicity (for the user). |
@mbrookes yup, that one is a real buzzkiller. But before we implement that, we should fix the docs so that callback signatures are formally documented. |
Agree completely, just wanted to throw it out there as a related point. All in good time. :) |
Callbacks are becoming the first class citizens of material-ui, so, their signature must be formally documented.
@mbrookes I added that to the list, thanks 👍 |
@subjectix I think this looks great! Thanks for pulling this together. |
@hai-cea Thank you 🎉 🎉 |
@oliviertassinari Is this ok? also check the line I added in the README.md.